This repository was archived by the owner on May 25, 2021. It is now read-only.
Sanity for AppRef.isStable observable #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feeloor
force-pushed
the
sanity-for-observable
branch
from
3667d8c to
3ff7f30
Compare
sumitarora
reviewed
Nov 18, 2019
| const roots = collectRoots(); | ||
| if (roots.length) { | ||
| let sanity; | ||
| const sanityThreshold = 0.5 * 1000; // 0.5 seconds |
There was a problem hiding this comment.
@feeloor Please add a comment explaining what is going on. Rest looks good to me.
There was a problem hiding this comment.
@sumitarora I've now added a few comments. 👍
feeloor
force-pushed
the
sanity-for-observable
branch
from
31989de to
462ccb4
Compare
sumitarora
approved these changes
Nov 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In larger applications, we sometimes encounter the
appRef.isStableobservable to fire constantly which is causing us to constantly send pings and updates, this in turn is making larger applications almost unusable.To prevent this I've added a sanity check to make sure that we only emit at the most twice per second.
Related issues: #1320 possibly #1402