Skip to content
This repository was archived by the owner on May 25, 2021. It is now read-only.

Task 804 input output example #847

Merged
merged 4 commits into from
Dec 2, 2016
Merged

Task 804 input output example #847

merged 4 commits into from
Dec 2, 2016

Conversation

rajinder-yadav
Copy link
Contributor

@rajinder-yadav rajinder-yadav commented Dec 1, 2016

resolved #804

@mention-bot
Copy link

Unable to parse mention-bot custom configuration file due to a syntax error.
Please check the potential root causes below:

  1. Having comments
  2. Invalid JSON type
  3. Having extra "," in the last JSON attribute

@stevenkampen
Copy link
Contributor

@rajinder-yadav Tested working, and I think it's a good example of the input/output feature, but I wonder if the UI could be improved so it's easier to see what you're looking at, at a quick glance. What do you think?

@sumitarora
Copy link
Member

sumitarora commented Dec 2, 2016

@rajinder-yadav I agree with @stevenkampen UI needs more ❤️ also few more things.

  • Toggle didn't work for me when I manually changed it in augury from true to false
  • It only seems to be working first time might be an augury issue
  • I see basscss errors in console while running app
  • We should also update readme with description about the example (add link to guide)

@rajinder-yadav
Copy link
Contributor Author

@sumitarora in the IO App, state property seems broken is Augury, you're correct it only works once. I also notice the value does not update in Augury if I click on the toggle button.

As for basscss error it looks like it's something to do with the CDN. I'm going to update the code to use their npm module for everything is a plugin!!!

Good idea about adding a link to the guide in the README, might be a better idea to just add a link on the app? Something like, "Take me to the Guide."

Rajinder Yadav added 4 commits December 2, 2016 15:07
Correct component camel casing names.

Added basecss and Roboto fonts

Initial io example app commit.

Layout work complete.

Switch to using ngSubmit event handling.
@rajinder-yadav
Copy link
Contributor Author

Switched code to use basscss npm modules.

@rajinder-yadav rajinder-yadav merged commit a900fbc into rangle:dev Dec 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants