Add SMB to HTTP relay support for get_naa_creds #19952
Draft
+698
−420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jheysel-r7
force-pushed
the
get_naa_creds_via_relay
branch
from
0be2ca6 to
a1b9b8f
Compare
jheysel-r7
commented
Mar 7, 2025
| @@ -84,7 +84,7 @@ def relay_ntlmssp_type3(client_type3_msg) | |||
| ) | |||
| res = @client.send_recv(req, @timeout, true) | |||
|
|
|||
| if res.code.between?(200, 299) | |||
| if res.code.between?(200, 299) || res.code == 403 | |||
There was a problem hiding this comment.
The response code which indicates the NTLM relay was successful needs to be configurable from the module. Stay tuned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drafting the working module for visibility, currently working on some refactoring.