Update primitives to better follow STL/thrust conventions in supporting predicate operations #4946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
seunghwak
changed the title
seunghwak
added
improvement
seunghwak
changed the title
KyleFromNVIDIA
approved these changes
Feb 25, 2025
ChuckHastings
approved these changes
Feb 28, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STL/thrust algorithms that conditionally process array elements have naming convention including
if(e.g. copy_if, transform_if, ...) and takes a separate predicate operator.cuGraph C++ primitives have been taking a single operator that returns cuda::std::nullopt (to discard the result) and a valid cuda::std::optional object for elements to be processed.
This PR updates cuGraph C++ primitives to take a separate predicate operator and use
ifin primitive names to better follow STL/thrust convention.