increase default HPN Buffer Size #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHAN_SES_WINDOW_DEFAULT is now 2mb, so increase the HPN buffer to once again be larger than the default
Match the default set in ssh.c
The default in OpenSSH changed from 64KB to 2MB, and this patch bumps the HPN default to 4MB
|
Allan, Sorry to take so long to reply. There is an annoying but valid reason to keep the default size at 2MB. Older implementations of OpenSSH (3.8 and older) will crash and burn if a buffer size larger than 2MB is advertised. Since we need to maintain backwards compatibility we have to maintain that limit. We could get around this with more explicit version checking. This can be done but I dont' have the spare cycles to work on it at the moment. Chris |
chutz
pushed a commit
to chutz/openssh-portable
that referenced
this pull request
Apr 19, 2019
Remove unused sKerberosTgtPassing from enum. From calestyo via github pull req rapier1#11, ok djm@ OpenBSD-Commit-ID: 1008f8870865a7c4968b7aed402a0a9e3e5b9540
nh2
reviewed
Sep 19, 2020
| @@ -32,10 +32,10 @@ http://www.psc.edu/networking/projects/hpn-ssh | |||
| BUFFER SIZES: | |||
|
|
|||
| If HPN is disabled the receive buffer size will be set to the | |||
| OpenSSH default of 64K. | |||
| OpenSSH default of 2MB. | |||
There was a problem hiding this comment.
I've extracted this correction into PR #24.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHAN_SES_WINDOW_DEFAULT is now 2mb, so increase the HPN buffer to once again be larger than the default