cipher: Restore DisableMTAES capability to resolve FIPS SIGSEGV. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the functionality provided in 9ed8887 and 4a535c4, but was then removed in the 9.2 -> 9.3 rebase process, as I mentioned in the FIPS bug thread. In my preliminary testing, this patch allows our FIPS servers to talk to each other happily, so long as both sides of the conversation use
DisableMTAES=yes. We (ServiceNow) will do some more testing on this as we can, but I'm submitting this upstream for the greater benefit, and hopefully to get some more-qualified-than-my-own eyes on this :)