-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequential Feaute Selection CPU utilization #191
Comments
I agree, in typical use cases the number of features should be larger than the number of folds in CV, so the multiprocessing should run over the features not the folds. This should be relatively easy to change via the multiprocessing submodule or mputil, will take a look at that some time |
I want to make this enchancement, but unit test failed on my laptop #192 |
Thanks for working on it. How did the unittests fail? Maybe just submit a PR and I could take a look! :) |
CPU per feature implementation gives results for various n_jobs, test.py in same gist. I can create new pull request today after fixing "Can't pickle <class 'method'>" for older pythons |
Thanks! I am looking forward to the PR and be happy to give you some feedback then.
Which versions of Python would that be? Currently, the package supports the latest 2.7 version, 3.5, and 3.6. Is any of these causing problems? In general, if older Python versions (e.g., 2.6, 3.3, 3.4) work, that's nice, but I wouldn't make backwards compatible changes to support these if it adds to the code complexity |
I met this problem on python 3.3.2. This is CentOS 6.7, kind of a target platform for me and system with 64 CPUs. Thats why it is so important. There is two ways to fix this. None of them adds much to code complexity. I like first one more. |
For multiple CPU utilization SFS uses sklearn.model_selection.cross_val_score. It runs one process per validation fold. Usually there are more features than folds. So, it is more scalable to use one process per feature.
The text was updated successfully, but these errors were encountered: