Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sklearn normalize depreciation fix #1036

Merged
merged 3 commits into from
May 17, 2023
Merged

Sklearn normalize depreciation fix #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d39b286
sklearn LinerRegression depreciation bug fixed
namanmistry May 16, 2023
6279cc1
Fixed LinearRegression Depreciation
namanmistry May 16, 2023
ea83ad6
move entry to the most recent section
rasbt May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/sources/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The CHANGELOG for the current development version is available at

##### Changes

- ...
- Changed the signature of the `LinearRegression` model of sklearn in the test removing the `normalize` parameter as it is deprecated. ([#1036](https://github.com/rasbt/mlxtend/issues/1036))

##### New Features and Enhancements

Expand Down
2 changes: 1 addition & 1 deletion mlxtend/regressor/tests/test_stacking_cv_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ def test_multivariate():
def test_multivariate_class():
lr = LinearRegression()
ridge = Ridge(random_state=1)
meta = LinearRegression(normalize=True)
meta = LinearRegression()
stregr = StackingCVRegressor(
regressors=[lr, ridge], meta_regressor=meta, multi_output=True, random_state=0
)
Expand Down
2 changes: 1 addition & 1 deletion mlxtend/regressor/tests/test_stacking_regression.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def test_multivariate():
def test_multivariate_class():
lr = LinearRegression()
ridge = Ridge(random_state=1)
meta = LinearRegression(normalize=True)
meta = LinearRegression()
stregr = StackingRegressor(
regressors=[lr, ridge], meta_regressor=meta, multi_output=True
)
Expand Down