-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add stacking param tuning #254
Conversation
Hello @jrbourbeau! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on September 20, 2017 at 03:24 Hours UTC |
@rasbt I think this PR might be good to go. Let me know if you see any issues! Note: I didn't make any additions to the tests for |
Thanks a lot, I really appreciate that! The PR looks perfect, and I think that although |
No problem, thanks for all your work on |
Description
Currently the parameters in
StackingClassifier
,StackingCVClassifier
,StackingRegressor
,StackingCVRegressor
, andEnsembleVoteClassifier
can't be tuned inGridSearchCV
. This PR fixes that bug.Related issues or pull requests
Fixes #253
Pull Request requirements
./mlxtend/*/tests
directoriesnosetests ./mlxtend -sv
and make sure that all unit tests passnosetests ./mlxtend --with-coverage
flake8 ./mlxtend
./docs/sources/CHANGELOG.md
filemlxtend/docs/sources/
(optional)