-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recursive floating for SequentialFeatureSelector #262
Conversation
I simplified the implementation a little bit using two nested while-loops now. This is doing exactly the same as before with |
just saw that we had the discussion in the other thread, so I am just pinging you here ;) @nd26 |
Description
Adds an recursive_floating parameter to the
SequentialFeatureSelector
:Related issues or pull requests
Fixes #243
Pull Request requirements
./mlxtend/*/tests
directoriesnosetests ./mlxtend -sv
and make sure that all unit tests passnosetests ./mlxtend --with-coverage
flake8 ./mlxtend
./docs/sources/CHANGELOG.md
filemlxtend/docs/sources/
(optional)More todos:
recursive_floating=False
(only iffloating=True
to avoid being too annoying) mentioning that this will berecursive_floating=True
in mlxtend >= v0.10