fix for issue 586

[sohrabtowfighi]

Description

Related issues or pull requests

Pull Request Checklist

• Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
• Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
• Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
• Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  No test found. Basic run on my own end worked.
• Checked for style issues by running flake8 ./mlxtend
  I don't have flake8. changes were minimal.

[pep8speaks]

Hello @sohrabtowfighi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-09-15 22:42:57 UTC

[coveralls]

Coverage decreased (-0.02%) to 92.329% when pulling 5a6a0d7 on pySRURGS:master into 5565b2b on rasbt:master.

[rasbt]

Thanks for the PR! Since we have no unit tests for the behavior of the plotting functions, could you update the examples in the jupyer notebook documentation to assess whether the changes work as intended? The respective file would be in https://github.com/rasbt/mlxtend/blob/master/docs/sources/user_guide/plotting/plot_decision_regions.ipynb

[sohrabtowfighi]

I ran the file you said. Looks the same except I got a FileNotFoundError at the very last line. I can't find the file and this seems unrelated to my commit.

In [23]:
with open('../../api_modules/mlxtend.plotting/plot_decision_regions.md', 'r') as f:
print(f.read())

[rasbt]

Oh that's because those are not explicitly saved on/commited to the GitHub repo (to save space). These are the function and class documentations that get directly extracted from the docstrings.

So, all you would need to do is

a) cd into the docs subdirectory, for example

cd ~/code/mlxtend/docs/

b) in this folder, run the make_api.py script

python3 make_api.py

This will generate all the up-to-date .md files.

[sohrabtowfighi]

I got this error

File "C:\Users\sohra\Anaconda3\lib\site-packages\skimage\util\arraycrop.py", line 8, in
from numpy.lib.arraypad import _validate_lengths
ImportError: cannot import name '_validate_lengths'

I also don't think this is related to my commit and I have a fixed copy of plot_confusion_matrix already in my code. I don't think I will go further in this rabbit hole.

[rasbt]

Hm weird. In any case, no need to dig into that further. Could you pls upload the updated jupyter notebook you mentioned? No need to execute the last cell (the one which caused the error); I can take care of that later