-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add decision function method for stacking classifiers #634
Conversation
Hello @qiagu! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2019-12-07 19:18:05 UTC |
The roc_auc score calculated in scikit-learn v0.20.3 is different from the one in v0.21.3. I couldn't figure out what parameter caused the discrepancy. |
Thanks for the PR. Looks pretty good so far! Regarding
I found this in the changelog (https://scikit-learn.org/dev/whats_new/v0.21.html#sklearn-svm): Maybe you can
E.g., from distutils.version import LooseVersion as Version
from sklearn import __version__ as sklearn_version
...
def test ...():
# test code
if Version(sklearn_version) > Version("0.21.3"):
assert ...
else:
assert ... |
@rasbt Thanks. Your suggestion always makes the most sense. I stop trying other things. |
@rasbt Do we need to care about the minor decrease of test coverage? |
No worries, that's fine. The change is so small that it is basically non-existent. I am currently a bit swamped with deadlines but let me go over the code again carefully on the upcoming weekend. Thanks for the PR so far! |
Looks great! I just added some examples to the jupyter notebook. Once the test passed, it should be good to merge. Many thanks! |
Thanks for merging. @rasbt |
Description
Related issues or pull requests
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)PYTHONPATH='.' pytest ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend