-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of both use_clones and fit_base_estimators #670
Conversation
…eVoteClassifier, StackingClassifier and StackingCVClassifier as well as tests for these to parameters
Hello @nilichen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-04-04 04:33:47 UTC |
51df689
to
2aad039
Compare
30ccf6f
to
2235bef
Compare
2235bef
to
fac152b
Compare
Sorry about that. Sure, i can restart it. However, I have seen this a couple of times recently. Let me try a little modification to see if it fixes it. |
Thanks! Do you mind taking a look at this PR first? I think it's already a lot of change changes. Gonna make another one for StackingRegressor and StackingCV if this one looks good to you. |
Thanks, and I will look at this soon! Sry, things are a bit crazy here due to the transition to online teaching etc. Will get back to this as soon as the more pressing things got sorted out |
Ah. No worries. Take your time!
…On Fri, Mar 13, 2020 at 9:55 AM Sebastian Raschka ***@***.***> wrote:
Thanks, and I will look at this soon! Sry, things are a bit crazy here due
to the transition to online teaching etc. Will get back to this as soon as
the more pressing things got sorted out
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#670 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACFAWHZA7S4G7K3GSEFCYFDRHJQR3ANCNFSM4LGV2FPA>
.
|
Thanks again for the PR. I made some minor updates but it looks great overall. |
Description
This PR is to implement both use_clones and fit_base_estimators (previously called refit in EnsembleVoteClassifier) for EnsembleVoteClassifier and StackingClassifier. As well as added corresponding tests for these two parameters.
Will have another PR to address StackingRegressor and StackingCVRegressor.
Related issues or pull requests
Towards #627. See also #383.
Pull Request Checklist
./docs/sources/CHANGELOG.md
file (if applicable)./mlxtend/*/tests
directories (if applicable)mlxtend/docs/sources/
(if applicable)PYTHONPATH='.' pytest ./mlxtend -sv
and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g.,PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv
)flake8 ./mlxtend