Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove depr. res from plot_decision_regions #803

Merged
merged 1 commit into from
Mar 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/sources/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ The CHANGELOG for the current development version is available at
##### Changes

- Updates unit tests for scikit-learn 0.24.1 compatibility. ([#774](https://github.com/rasbt/mlxtend/pull/774))
- Removes deprecated `res` argument from `plot_decision_regions`. ([#803](https://github.com/rasbt/mlxtend/pull/803))

##### Bug Fixes

Expand Down
15 changes: 0 additions & 15 deletions mlxtend/plotting/decision_regions.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def plot_decision_regions(X, y, clf,
filler_feature_ranges=None,
ax=None,
X_highlight=None,
res=None,
zoom_factor=1.,
legend=1,
hide_spines=True,
Expand Down Expand Up @@ -93,13 +92,6 @@ def plot_decision_regions(X, y, clf,
one if ax=None.
X_highlight : array-like, shape = [n_samples, n_features] (default: None)
An array with data points that are used to highlight samples in `X`.
res : float or array-like, shape = (2,) (default: None)
This parameter was used to define the grid width,
but it has been deprecated in favor of
determining the number of points given the figure DPI and size
automatically for optimal results and computational efficiency.
To increase the resolution, it's is recommended to use to provide
a `dpi argument via matplotlib, e.g., `plt.figure(dpi=600)`.
zoom_factor : float (default: 1.0)
Controls the scale of the x- and y-axis of the decision plot.
hide_spines : bool (default: True)
Expand Down Expand Up @@ -135,13 +127,6 @@ def plot_decision_regions(X, y, clf,
if ax is None:
ax = plt.gca()

if res is not None:
warnings.warn("The 'res' parameter has been deprecated."
"To increase the resolution, it's is recommended"
"to use to provide a `dpi argument via matplotlib,"
"e.g., `plt.figure(dpi=600)`.",
DeprecationWarning)

plot_testdata = True
if not isinstance(X_highlight, np.ndarray):
if X_highlight is not None:
Expand Down