RD-12433: Test that assert Http URL parsing is correctly handling arguments #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgaidioz
commented
Aug 5, 2024
snapi-client/src/test/scala/raw/compiler/rql2/tests/regressions/RD10194Test.scala
Outdated
Show resolved
Hide resolved
bgaidioz
commented
Aug 5, 2024
snapi-client/src/test/scala/raw/compiler/rql2/tests/builtin/credentials/MySQLPackageTest.scala
Outdated
Show resolved
Hide resolved
bgaidioz
force-pushed
the
remove-creds-with-fix-raw-value-ben-test
branch
2 times, most recently
from
163edaa to
db08073
Compare
bgaidioz
force-pushed
the
remove-creds-with-fix-raw-value-ben-test
branch
from
db08073 to
7256809
Compare
bgaidioz
force-pushed
the
remove-creds-with-fix-raw-value-ben-test
branch
2 times, most recently
from
a6efdf6 to
6c15bfa
Compare
bgaidioz
force-pushed
the
remove-creds-with-fix-raw-value-ben-test
branch
from
6c15bfa to
39a38c8
Compare
bgaidioz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The added
HttpPackageTesttests passing args are passing. Because we pass the URL to a library which figures out. The most challenging one is where half of the args is passed in the URL, and the other half as a formal list of arguments, they're merged because the library sorts it out.Hence I remove the "TODO" comment that was in the code since there's nothing to do (?)
Also added a CSV test making sure we correctly handle a mistakenly passed directory (in place of a file).