-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for autoscaler and its desired state #2601
Add test for autoscaler and its desired state #2601
Conversation
223031d
to
fe713c5
Compare
Signed-off-by: hjiang <[email protected]>
fe713c5
to
7e59297
Compare
would you mind fixing the CI errors? |
Emmm ok, though it seems unrelated to my change
|
Signed-off-by: hjiang <[email protected]>
Updated. |
@MortalHappiness would you mind reviewing this PR? |
By the way, |
Signed-off-by: hjiang <[email protected]>
I'm following the existing coding style |
Yes, I know. I just found it redundant, so I mentioned that it is not related to this PR. However, removing it might make it easier for you to implement this test. It's up to you whether to remove it or keep it. I'll create a separate PR to remove them though. |
Signed-off-by: hjiang <[email protected]>
Signed-off-by: hjiang <[email protected]>
@MortalHappiness Updated PTAL |
BTW please fix linter issue |
Signed-off-by: hjiang <[email protected]>
Signed-off-by: hjiang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #2575
This PR adds a integration for autoscaling, basically spins up a bunch of tasks and check whether max pod replica count has reached during the process.