[Bug] TestRayServiceInPlaceUpdate is flaky #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
4 tasks
MortalHappiness
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Increase the timeout from 30m to 60m because the time for a normal run needs around 27 ~ 30m. We should divide these tests into different runners in the future.
Add
Eventuallyto check the request's response. The reason is that Ray Serve initially launches with its default values, which are then overwritten by serveConfigV2.Related issue number
Closes #2617
Checks
I ran
TestRayServiceInPlaceUpdatethree times for #2611. It failed the first two times. Additionally, the test failed three times in #2588. Hence, the tests failed 5 times out of 6 runs.I triggered this PR's CI three times, and all runs passed.