Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a util function to convert string and bytes array #2621

Merged
merged 7 commits into from
Dec 10, 2024

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Dec 6, 2024

Reading through the code, I found we have several places converting between byte array and string type.
For example:

Add a util function to apply zero-copy strategy to these conversions.

Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some comments

@dentiny
Copy link
Contributor Author

dentiny commented Dec 9, 2024

Can you add some comments

Sure, add a warning to the post-condition, also an example for usage.

@dentiny dentiny requested a review from kevin85421 December 9, 2024 23:07
@kevin85421 kevin85421 merged commit 073de1f into ray-project:master Dec 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants