[kubectl-plugin] add create workergroup command #2673
Merged
+194
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
andrewsykim
changed the title
andrewsykim
force-pushed
the
kubectl-plugin
branch
2 times, most recently
from
b24ce5f to
93fb2db
Compare
chiayi
reviewed
Jan 14, 2025
| @@ -154,7 +153,6 @@ func NewJobSubmitCommand(streams genericclioptions.IOStreams) *cobra.Command { | |||
| cmd.Flags().StringVar(&options.image, "image", "rayproject/ray:2.39.0", "Ray image to use in the Ray Cluster yaml") | |||
| cmd.Flags().StringVar(&options.headCPU, "head-cpu", "2", "Number of CPU for the ray head") | |||
| cmd.Flags().StringVar(&options.headMemory, "head-memory", "4Gi", "Amount of memory to use for the ray head") | |||
| cmd.Flags().StringVar(&options.workerGrpName, "worker-grp-name", "default-group", "Name of the worker group for the Ray Cluster") | |||
There was a problem hiding this comment.
I can't comment on the other parts but in the job submit examples section, we still have the worker-grp-name. Line 98 and 101
There was a problem hiding this comment.
thanks, removed from examples
chiayi
reviewed
Jan 14, 2025
|
|
||
| createWorkerGroupExample = templates.Examples(` | ||
| # Create a worker group in an existing RayCluster | ||
| kubectl ray create worker-group gpu-group --cluster sample-cluster --image rayproject/ray:2.39.0 --worker-gpu 1 --worker-memory=5Gi |
andrewsykim
force-pushed
the
kubectl-plugin
branch
from
93fb2db to
cbee720
Compare
kevin85421
approved these changes
Jan 15, 2025
andrewsykim
force-pushed
the
kubectl-plugin
branch
from
cbee720 to
ef9b923
Compare
Signed-off-by: Andrew Sy Kim <[email protected]>
andrewsykim
force-pushed
the
kubectl-plugin
branch
from
ef9b923 to
0056d78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add a command to add new worker groups to existing RayClusters
Related issue number
#2608
Checks