[RayService] Avoid sending health check requests to the head Pod when excludeHeadPodFromServeSvc is true
#2776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
kevin85421
commented
Jan 20, 2025
| @@ -121,7 +120,6 @@ func (r *RayServiceReconciler) Reconcile(ctx context.Context, request ctrl.Reque | |||
| originalRayServiceInstance := rayServiceInstance.DeepCopy() | |||
|
|
|||
| if err := validateRayServiceSpec(rayServiceInstance); err != nil { | |||
| logger.Error(err, "The RayService spec is invalid") | |||
There was a problem hiding this comment.
The error will be returned in Reconcile, so controller runtime will handle it. No need to print it.
| @@ -1135,8 +1133,6 @@ func (r *RayServiceReconciler) reconcileServe(ctx context.Context, rayServiceIns | |||
| } | |||
| } | |||
|
|
|||
| // TODO(architkulkarni): Check the RayVersion. If < 2.8.0, error. | |||
There was a problem hiding this comment.
No one has complained about it for years. Remove the TODO.
| @@ -1183,29 +1183,29 @@ func (r *RayServiceReconciler) labelHeadPodForServeStatus(ctx context.Context, r | |||
| return fmt.Errorf("found 0 head. cluster name %s, namespace %v", rayClusterInstance.Name, rayClusterInstance.Namespace) | |||
| } | |||
|
|
|||
| httpProxyClient := r.httpProxyClientFunc() | |||
There was a problem hiding this comment.
httpProxy is not very precise.
| for key, value := range headPod.Labels { | ||
| originalLabels[key] = value | ||
| } | ||
| if err = httpProxyClient.CheckProxyActorHealth(ctx); err == nil && !excludeHeadPodFromServeSvc { |
There was a problem hiding this comment.
If excludeHeadPodFromServeSvc is true, we don't need to send health check requests to the head Pod.
|
cc @rueian |
MortalHappiness
approved these changes
Jan 20, 2025
win5923
pushed a commit
to win5923/kuberay
that referenced
this pull request
Jan 20, 2025
… `excludeHeadPodFromServeSvc` is true (ray-project#2776) Signed-off-by: kaihsun <[email protected]>
win5923
pushed a commit
to win5923/kuberay
that referenced
this pull request
Jan 20, 2025
… `excludeHeadPodFromServeSvc` is true (ray-project#2776) Signed-off-by: kaihsun <[email protected]>
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks