[RayService] Always check the readiness of head Pods for both pending / active clusters if cluster exists #2783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
kevin85421
commented
Jan 21, 2025
| @@ -211,9 +222,6 @@ func (r *RayServiceReconciler) Reconcile(ctx context.Context, request ctrl.Reque | |||
| if err := r.reconcileServices(ctx, rayServiceInstance, rayClusterInstance, utils.HeadService); err != nil { | |||
| return ctrl.Result{RequeueAfter: ServiceDefaultRequeueDuration}, err | |||
| } | |||
| if err := r.updateHeadPodServeLabel(ctx, rayClusterInstance, rayServiceInstance.Spec.ExcludeHeadPodFromServeSvc); err != nil { | |||
There was a problem hiding this comment.
Originally, if both active and pending clusters exist, only the head Pod of the pending cluster will have its status checked. That is, if the active cluster's head Pod's serve status fails during the upgrade process, it will not be detected in time.
| } | ||
|
|
||
| if err != nil { | ||
| return err | ||
| } | ||
| logger.Info("reconcileServices", "newSvc", newSvc) |
There was a problem hiding this comment.
very verbose and not that useful
|
cc @rueian |
MortalHappiness
approved these changes
Jan 21, 2025
This was referenced Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Originally, if both active and pending clusters exist, only the head Pod of the pending cluster will have its status checked. That is, if the active cluster's head Pod's serve status fails during the upgrade process, it will not be detected in time.
This PR checks the readiness of head Pods for both pending / active clusters if exist.
Related issue number
Checks