[RayService] e2e for check the readiness of head Pods for both pending / active clusters #2806
+150
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
force-pushed
the
e2e-rayservice-readiness
branch
from
2f29285 to
c314ca1
Compare
rueian
commented
Jan 23, 2025
Comment on lines
100
to
106
| g.Eventually(func(g Gomega) int { | ||
| heads, err := test.Client().Core().CoreV1().Pods(namespace.Name).List(test.Ctx(), metav1.ListOptions{ | ||
| LabelSelector: "ray.io/serve=true", | ||
| }) | ||
| g.Expect(err).NotTo(HaveOccurred()) | ||
| return len(heads.Items) | ||
| }, TestTimeoutShort).Should(Equal(2)) |
There was a problem hiding this comment.
Since we manually delete the label from the active cluster before the upgrade, this condition ensures we check the readiness for both active and pending clusters.
kevin85421
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Discussed offline:
- Create a RayService
- Wait until the active cluster to be running, and has X endpoints
- Trigger zero downtime upgrade. Pending cluster should take a long time to ready (e.g. add a init container to sleep)
- Make the proxy actor on the active cluster's head Pod fail and can't receive requests.
- Check the number of endpoints become
X-1.
| serveConfig = strings.Replace(serveConfig, "factor: 5", "factor: 3", -1) | ||
|
|
||
| // modify EnableInTreeAutoscaling to trigger a zero downtime upgrade. | ||
| rayService.Spec.RayClusterSpec.EnableInTreeAutoscaling = ptr.To[bool](true) |
There was a problem hiding this comment.
RayVersion seems to be a safer option.
There was a problem hiding this comment.
The newly added init container can already trigger the zero downtime upgrade.
…g / active clusters Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
e2e-rayservice-readiness
branch
2 times, most recently
from
4bd018c to
ba5bea2
Compare
rueian
commented
Jan 24, 2025
| @@ -24,10 +24,6 @@ func TestRayServiceInPlaceUpdate(t *testing.T) { | |||
|
|
|||
| rayServiceAC := rayv1ac.RayService(rayServiceName, namespace.Name).WithSpec(rayServiceSampleYamlApplyConfiguration()) | |||
|
|
|||
| // TODO: This test will fail on Ray 2.40.0. Pin the Ray version to 2.9.0 as a workaround. Need to remove this after the issue is fixed. | |||
| rayServiceAC.Spec.RayClusterSpec.WithRayVersion("2.9.0") | |||
…g / active clusters Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
e2e-rayservice-readiness
branch
from
ba5bea2 to
34e10d4
Compare
|
I will open a follow up PR if needed. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Resolves #2787
Related issue number
Checks