[Refactor][RayService] Add conditions to RayService #2807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MortalHappiness
force-pushed
the
feature/#2751-rayservice-conditions
branch
4 times, most recently
from
49d64e6 to
5cccedc
Compare
MortalHappiness
force-pushed
the
feature/#2751-rayservice-conditions
branch
from
03228b6 to
8f6e447
Compare
kevin85421
reviewed
Jan 25, 2025
| @@ -128,6 +129,15 @@ func (r *RayServiceReconciler) Reconcile(ctx context.Context, request ctrl.Reque | |||
| // TODO (kevin85421): ObservedGeneration should be used to determine whether to update this CR or not. | |||
| rayServiceInstance.Status.ObservedGeneration = rayServiceInstance.ObjectMeta.Generation | |||
|
|
|||
| // Initialize conditions for RayService. | |||
There was a problem hiding this comment.
we should try to not to add a new place to call Status().Update(). You can remove it from this PR for now and open an issue to track the progress.
Closes: ray-project#2751 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#2751 Signed-off-by: Chi-Sheng Liu <[email protected]>
Closes: ray-project#2751 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#2751-rayservice-conditions
branch
from
8f6e447 to
96ca6d7
Compare
kevin85421
approved these changes
Jan 26, 2025
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR implements
ReadyandUpgradeInProgressconditions forRayService.Related issue number
Closes: #2751
Checks