Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(default-storage): Bump versions #1094

Merged
merged 5 commits into from
Jun 6, 2024
Merged

Conversation

krizzu
Copy link
Member

@krizzu krizzu commented May 7, 2024

Summary

Bumped native dependencies:

  • kotlin
  • room
  • ksp
  • coroutines
  • test-app

@krizzu krizzu requested a review from tido64 as a code owner May 7, 2024 09:57
@krizzu krizzu force-pushed the default-storage/version-bumps branch from d8079fe to aa761df Compare May 7, 2024 13:06
@krizzu
Copy link
Member Author

krizzu commented May 7, 2024

@tido64
due to macOS failing with:

/Users/runner/work/async-storage/async-storage/packages/default-storage/example/macos/Pods/boost/boost/container_hash/hash.hpp:131:33: error: no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
struct hash_base : std::unary_function<T, std::size_t> {};
~~~~~^~~~~~~~~~~~~~
** BUILD FAILED **

I bumped test-app to latest 3.7.0, but now I cannot get it to run due to

05-07 15:02:45.407 10198 10198 E AndroidRuntime: java.lang.ExceptionInInitializerError
05-07 15:02:45.407 10198 10198 E AndroidRuntime: at com.microsoft.reacttestapp.TestApp.onCreate(TestApp.kt:34)

// omitted for brevity

05-07 15:02:45.407 10198 10198 E AndroidRuntime: Caused by: java.lang.IllegalStateException: SoLoader.init() not yet called

05-07 15:02:45.407 10198 10198 E AndroidRuntime: at com.facebook.soloader.SoLoader.assertInitialized(SoLoader.java:1172)

// omitted for brevity

05-07 15:02:45.407 10198 10198 E AndroidRuntime: at com.facebook.react.defaults.DefaultNewArchitectureEntryPoint.load$default(DefaultNewArchitectureEntryPoint.kt:27)

05-07 15:02:45.407 10198 10198 E AndroidRuntime: at com.microsoft.reacttestapp.compat.ReactNativeHostCompat.(ReactNativeHostCompat.kt:15)

Do you have any idea about this one?

@tido64
Copy link
Member

tido64 commented May 7, 2024

Do you have any idea about this one?

It's a bug 😛: microsoft/react-native-test-app#2024

For iOS/macOS, you will want to wait for this one as well: microsoft/react-native-test-app#2023

@krizzu
Copy link
Member Author

krizzu commented May 13, 2024

@tido64 I bumped to latest test-app, but macOS still fails when compiling headers, do you mind having a look here?

error: 'atomic' attribute on property 'clipsToBounds' does not match the property inherited from 'NSView'

@tido64
Copy link
Member

tido64 commented May 13, 2024

@tido64 I bumped to latest test-app, but macOS still fails when compiling headers, do you mind having a look here?

error: 'atomic' attribute on property 'clipsToBounds' does not match the property inherited from 'NSView'

We probably need to bumpreact-native-macos. This looks like the sort of error you'd get when the SDK changes. I'll try taking a look later this week some time.

@krizzu krizzu force-pushed the default-storage/version-bumps branch from 16979df to 1091dcd Compare June 6, 2024 11:22
@krizzu krizzu requested a review from tido64 June 6, 2024 11:44
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, and sorry it took so long to resolve the build issues.

@krizzu krizzu merged commit de83d14 into main Jun 6, 2024
9 checks passed
@krizzu krizzu deleted the default-storage/version-bumps branch June 6, 2024 13:11
@VMBindraban

This comment has been minimized.

@VMBindraban

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants