Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update mock implementation url in Jest integration docs #1126

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

a-fortunato
Copy link
Contributor

@a-fortunato a-fortunato commented Jul 18, 2024

Summary

Hi! ☀️

I noticed that the url to AsyncStorageMock files in the Jest docs were leading to a page not found error.

Screenshot 2024-07-18 at 19 14 14

I found what I think is the correct url and replaced it. 😄

Screenshot 2024-07-18 at 19 16 41

Test Plan

Just go to the url and check if it's the correct one to the mocks implementation :)

Thank you! 🙌🏼

Copy link

changeset-bot bot commented Jul 18, 2024

⚠️ No Changeset found

Latest commit: 3bff639

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@a-fortunato a-fortunato changed the title Update mock files url in Jest integration docs docs: update mock files url in Jest integration docs Jul 18, 2024
@a-fortunato a-fortunato changed the title docs: update mock files url in Jest integration docs docs: update mock implementation url in Jest integration docs Jul 18, 2024
Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@tido64 tido64 enabled auto-merge (squash) July 19, 2024 05:57
@tido64 tido64 merged commit 1aaf440 into react-native-async-storage:main Jul 19, 2024
8 checks passed
@a-fortunato
Copy link
Contributor Author

a-fortunato commented Jul 22, 2024

hey @tido64, do you know why this is still not pointing to the correct url in the docs? 😢

is it related to the changeset comment? #1126 (comment)

Edit:
Ah, I see it's related to some other issue, and that you already pushed a fix.

@tido64
Copy link
Member

tido64 commented Jul 22, 2024

We had a deployment failure (logs), but it should be fixed now. It will hopefully be updated when we next trigger a website build (i.e. when #1131 merges).

Please bear with us 🐻

@a-fortunato
Copy link
Contributor Author

Got it, thank you! 😊✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants