Feature/3340 Add best-effort replay sink #3798
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still need a few tests to document this further |
|
I'm having pipeline issues with gradle on M1 Mac, so I'm stuck |
|
Closing as explained in #3340 (comment). |
chemicL
added
the
status/declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ArraySizeBoundReplayBuffer, and links it for the user via
Sink.many().replay().bestEffort().This new spec offer support for the purely size-bound buffer implementations. It adds
#limit(n),#latest()and#latestOrDefault(T), reflecting the same methods from its parent,Sink.many().replay().The
ArraySizeBoundReplayBufferin contrast to theSizeBoundReplayBufferwill never hold more than the stated items referenced. TheSizeBoundReplayBuffer, through theSubscription, will retain old references, such that they can be replayed to the subscriber. This is very correct, but can also make the buffer grow beyond its bounds, if a subscriber lacks request they will still be able to replay all elements, but these elements remain in memory. TheArraySizeBoundReplayBufferhold and replay only what is kept in the array.Fixes issues/3340