Add triggering examples with parentheses to the number separator rule tests #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the rule itself should be improved such that the violation always occurs outside the parentheses. If so, a new issue should be created for that. |
Here's an example of your CHANGELOG entry: * Add triggering examples with parentheses to the number separator rule tests.
[daltonclaybrook](https://github.com/daltonclaybrook)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improves #2683
I did not create a new changelog entry for this PR because it should have been implemented as part of #2687, but I'll be happy to add one anyway if necessary.
Due to how the number is parsed, the violation can occur either inside or outside the opening parenthesis depending on the sign, so I could not simply append new values inside the existing
makeTriggeringExamplesfunction. Let me know if you think this should be handled differently.