-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive in UnusedCaptureListRule #2726
Fix false positive in UnusedCaptureListRule #2726
Conversation
Here's an example of your CHANGELOG entry: * Fix false positive in UnusedCaptureListRule.
[daltonclaybrook](https://github.com/daltonclaybrook)
[#issue_number](https://github.com/realm/SwiftLint/issues/issue_number) note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
CHANGELOG.md
Outdated
@@ -95,6 +95,11 @@ | |||
[Frederick Pietschmann](https://github.com/fredpi) | |||
[#2670](https://github.com/realm/SwiftLint/issues/2670) | |||
|
|||
* Fix false positives on `unused_capture_list` which resulted in an array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog entry isn't necessary because this rule hasn't shipped in a release yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 epic, thanks for fixing so quickly. Let's just remove the unnecessary changelog entry and I'll merge.
Fixes concern raised by @jpsim here.
An array literal was being mistaken for a capture list in some cases.