Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Handle InterpolatedStringPart crash on RemoveUnusedForeachKeyRector #6457

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

samsonasik
Copy link
Member

Given the following code:

<?php

namespace Rector\Tests\Issues\IndentationCrash\PrintCrash;

final class InterpolatedStringPart
{
    public function test(array $checkInputs): void
    {
        foreach ($checkInputs as $index => $checkInput) {
            echo "Input#{$index}: Wrong tokenTime";
        }
    }
}

got crash:

There was 1 error:

1) Rector\Tests\Issues\PrintCrash\PrintCrashTest::test with data set #0 ('/Users/samsonasik/www/rector-...hp.inc')
Error: Call to undefined method Rector\PhpParser\Printer\BetterStandardPrinter::pInterpolatedStringPart()

@samsonasik
Copy link
Member Author

Fixed 🎉

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 2764b43 into main Nov 20, 2024
36 checks passed
@samsonasik samsonasik deleted the crash branch November 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant