Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php80] Fix end slash regex on AttributeValueResolver #6579

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

samsonasik
Copy link
Member

\r? end cause mac os new line detected, it will allow:

some with \

which should not.

@samsonasik
Copy link
Member Author

also updated explode to use our NewLineSplitter to ensure windows \r\n new line included on explode, not part of existing line that cause left over \r

@samsonasik
Copy link
Member Author

I added test for it, if after \, no new line, then keep it as a character, also add test for with new line without other text

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I am merging it ;)

@samsonasik samsonasik merged commit 3001e72 into main Dec 13, 2024
41 checks passed
@samsonasik samsonasik deleted the fix-end-slash-regex branch December 13, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant