Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing env definition #118

Closed
Tracked by #131
concaf opened this issue May 16, 2017 · 1 comment · Fixed by #121
Closed
Tracked by #131

Changing env definition #118

concaf opened this issue May 16, 2017 · 1 comment · Fixed by #121
Assignees
@concaf
Labels
backwards incompatible change status/work-in-progress

Comments

@concaf
Copy link
Collaborator

concaf commented May 16, 2017

Currently, environment variables are defined as -

    env:
    - foo=bar

This limits the ability to extend the environment variables, like supporting secrets.

Let's change the environment variables definition to -

    env:
    - name: foo
      value: bar
@concaf
Copy link
Collaborator Author

concaf commented May 17, 2017

picking this up

concaf added a commit to concaf/opencompose that referenced this issue May 17, 2017
@concaf
refactor env definition from a=b to name=a,value=b
1f0d325 
The environment variables have been declared in OpenCompose till
now as -

env:
- a=b
- x=y

This is essentially a list of strings, and this made it very
difficult to extend the environment variable definition with
other concepts like secrets, etc.

This commit changes the environment variable definition to -
env:
- name: a
  value: b
- name: x
  value: y

Also, this -
- fixes tests that were breaking
- removes tests which are not relevant anymore, e.g. the ones
  which checked if multiple "=" broke the environment variable
  unmarshalling or not
- adds tests which make sure the name: and value: are both
  required fields, and that they cannot be left blank
- does not add validation for environment variables being passed
- fix examples which had env: definitions in them
- fix file-reference.md to include the newer env: definition

fixes redhat-developer#118
@concaf concaf mentioned this issue May 17, 2017
Merged
@surajssd surajssd mentioned this issue May 18, 2017
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@concaf concaf

Labels
backwards incompatible change status/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor env definition from a=b to name: a,value: b concaf/opencompose
3 participants
@kadel @pradeepto @concaf