Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes object serialization and writing objects in
convert
. It was a FIXME and it didn't work until this PR.This PR will help us move forward a lot because it allows us to actually output deployable objects.
For reviewers:
It took me several hours to find the 4 magic lines by digging in Kubernetes sources; definitely no docs :(
This can't really break anything as it didn't work before :D
But I have tested it manually and we should cover it once we have E2E tests.