fix error output in kubernetes_test.go #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
suggested changes
Jun 5, 2017
| @@ -688,7 +688,7 @@ func TestTransformer_CreateDeployments(t *testing.T) { | |||
| } | |||
|
|
|||
| if !reflect.DeepEqual(kd, test.K8sDeployments) { | |||
| t.Errorf("Expected: %#v\nGot: %#v\n", test.K8sDeployments, kd) | |||
| t.Errorf("Expected: %#v\nGot: %#v\n", test.K8sDeployments[0], kd[0]) | |||
There was a problem hiding this comment.
hardcoding the index values is not very good, use something like spew.Sprint to get the string format of the entire object.
I have done something similar in my PR #143 at https://github.com/redhat-developer/opencompose/pull/143/files#diff-c04853213c3b672346e99815d4cf3e55R760
There was a problem hiding this comment.
Thanks, didn't about spew :)
TIL 👍
Fixed.
Currently, func TestTransformer_CreateDeployments(t *testing.T)
fails like -
Expected: []runtime.Object{(*v1beta1.Deployment)(0xc420290380)}
Got: []runtime.Object{(*v1beta1.Deployment)(0xc420290a80)}
After, this commit, the fields are printed, which makes it
possible to debug.
concaf
force-pushed
the
fix_error_test_message
branch
from
8d209d9 to
3f911e3
Compare
kadel
approved these changes
Jun 5, 2017
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, func TestTransformer_CreateDeployments(t *testing.T)
fails like -
Expected: []runtime.Object{(*v1beta1.Deployment)(0xc420290380)}
Got: []runtime.Object{(*v1beta1.Deployment)(0xc420290a80)}
After, this commit, the fields are printed, which makes it
possible to debug.