Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update examples #16

Merged
merged 1 commit into from
Feb 20, 2017
Merged

update examples #16

merged 1 commit into from
Feb 20, 2017

Conversation

kadel
Copy link
Member

@kadel kadel commented Feb 20, 2017

  • new single container example hello-nginx.yml
  • two container example - simple wordpress with mariadb without external storage

@tnozicka tnozicka self-requested a review February 20, 2017 14:10
tnozicka
tnozicka suggested changes Feb 20, 2017
View reviewed changes
examples/hello-nginx.yaml
containers:
- image: tomaskral/nonroot-nginx
ports:
- port: 8080
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing \n at the end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

tnozicka
tnozicka approved these changes Feb 20, 2017
View reviewed changes
Copy link
Contributor

@tnozicka tnozicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@tnozicka tnozicka merged commit 268c492 into redhat-developer:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnozicka tnozicka tnozicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kadel @tnozicka