Generate deployment only once #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment was generated per container. This commit fixes that behavior and generates only one deployment. This was not noticed before because in convert only files were generated so the extra file was over written. Now with the new feature of showing output to STDOUT this issue was discovered. Fixes redhat-developer#86
|
@tnozicka one question that builds on top of it is: Since we are passing it single service so it will generate only one deployment out of it right? |
|
the fact that we create one deployment now does not mean we always will, although at this point it's unlikely. There might by some new key under service that would require generating another deployment. So mostly for forward compatibility and to have same signature as similar functions |
kadel
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment was generated per container. This commit fixes that behavior and generates only one deployment.
This was not noticed before because in convert only files were generated so the extra file was over written.
Now with the new feature of showing output to STDOUT this issue was discovered.
Fixes #86