Avoid QUIT for broken connections

[sazzad16]

Note: Found it hard to write proper test codes. We may need to mock for this purpose.

[yangbodong22011]

Hi, @sazzad16, the code look good to me, but i don't think it will solve #2108 #2105

Under current jedis netWork protocol, if a operation timeouted, will set borken = true, then the socket will be closed. The reason is the socket may be return data after sometime, this may cause next operation get error response.

About this issue, i think the only way to avoid close connection is increase soTimeout.

[sazzad16]

@yangbodong22011 The object will be returned to the pool as a broken resource. The pool will remove it and never use it again. If necessarily, the pool will create a new resource which will have a new socket. Do you think it will still be a problem?

[yangbodong22011]

@yangbodong22011 The object will be returned to the pool as a broken resource. The pool will remove it and never use it again. If necessarily, the pool will create a new resource which will have a new socket. Do you think it will still be a problem?

This is the current logic, and it is correct. but create a new resource will cause #2105 (comment) .
One way to avoid connection broken is to avoid timeout, that is, increase soTimeout.

[sazzad16]

but create a new resource will cause #2105 (comment) .
One way to avoid connection broken is to avoid timeout, that is, increase soTimeout.

The goal of this PR is not to avoid creating new connections and solve #2105. The goal here is to avoid executing a Redis command (QUIT) with a connection which is already broken while trying to execute some other command.

If you are not convinced that this will resolve #2108, we can still keep the issue open and move forward with this PR.