Avoid using QUIT command #3353
Merged
Avoid using QUIT command #3353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yangbodong22011
commented
Apr 3, 2023
yangbodong22011
commented
Apr 3, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #3353 +/- ##
============================================
+ Coverage 67.02% 67.07% +0.04%
+ Complexity 4661 4657 -4
============================================
Files 263 263
Lines 15101 15072 -29
Branches 952 947 -5
============================================
- Hits 10122 10109 -13
+ Misses 4570 4556 -14
+ Partials 409 407 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sazzad16
suggested changes
Apr 3, 2023
Please refer to: redis/redis#11420 This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface `Jedis.quit()`. This optimizes Jedis connection pool performance and fixes: redis#2105 redis#2108
yangbodong22011
force-pushed
the
feature-deprecate-quit
branch
from
8abb09e to
4eceb1a
Compare
done |
yangbodong22011
changed the title
sazzad16
reviewed
Apr 5, 2023
dengliming
previously approved these changes
Apr 6, 2023
Co-authored-by: M Sazzadul Hoque <[email protected]>
Co-authored-by: M Sazzadul Hoque <[email protected]>
sazzad16
approved these changes
Apr 6, 2023
sazzad16
pushed a commit
to sazzad16/jedis
that referenced
this pull request
Apr 20, 2023
* Jedis avoid using QUIT command Please refer to: redis/redis#11420 This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface `Jedis.quit()`. This optimizes Jedis connection pool performance and fixes: redis#2105 * Update src/main/java/redis/clients/jedis/Connection.java Co-authored-by: M Sazzadul Hoque <[email protected]> * Apply suggestions from code review Co-authored-by: M Sazzadul Hoque <[email protected]> --------- Co-authored-by: M Sazzadul Hoque <[email protected]> --------- Conflicts: src/main/java/redis/clients/jedis/Connection.java src/main/java/redis/clients/jedis/ConnectionFactory.java src/main/java/redis/clients/jedis/Jedis.java src/main/java/redis/clients/jedis/Protocol.java
sazzad16
added a commit
that referenced
this pull request
Apr 20, 2023
Backport of #3353 --------- Please refer to: redis/redis#11420 This PR cancels calling the quit command when the Jedis internal link is abnormal, and deprecate the user interface `Jedis.quit()`. This optimizes Jedis connection pool performance and fixes: #2105 --------- Conflicts: src/main/java/redis/clients/jedis/Connection.java src/main/java/redis/clients/jedis/ConnectionFactory.java src/main/java/redis/clients/jedis/Jedis.java src/main/java/redis/clients/jedis/Protocol.java * more changes * Modify makeObject() for Jedis 3.x --------- Co-authored-by: bodong.ybd <[email protected]>
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Apr 27, 2023
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Apr 27, 2023
Address 'Address+Fix redis#3353'
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Apr 27, 2023
sazzad16
added a commit
to sazzad16/jedis
that referenced
this pull request
Apr 27, 2023
Address 'Address+Fix redis#3353'
sazzad16
added a commit
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to: redis/redis#11420
This PR cancels calling the quit command when the Jedis internal link is abnormal, but the user interface
Jedis.quit()is not affected. This optimizes Jedis connection pool performance and addresses #2105 and #2108See comments for some code details.