Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Flux/Mono.expand(…) for ScanStream #1458

Closed
mp911de opened this issue Oct 12, 2020 · 0 comments
Closed

Switch to Flux/Mono.expand(…) for ScanStream #1458

mp911de opened this issue Oct 12, 2020 · 0 comments
Labels
type: task A general task
Milestone
6.0.1

Comments

@mp911de
Copy link
Collaborator

mp911de commented Oct 12, 2020

ScanStream uses a custom Subscriber along with buffers/queues to emit SCAN results. We should investigate whether we can simplify the code by using Flux.expand(…).
@mp911de mp911de added the type: task A general task label Oct 12, 2020
@sokomishalov sokomishalov mentioned this issue Oct 21, 2020
Closed
mp911de pushed a commit that referenced this issue Oct 26, 2020
@sokomishalov @mp911de
ScanStream: replace custom emissions with Mono::expand #1458
4bfbe89 
Original pull request: #1468.
mp911de added a commit that referenced this issue Oct 26, 2020
@mp911de
Polishing #1458
c619497 
Reformat code. Add author tag.

Original pull request: #1468.
mp911de pushed a commit that referenced this issue Oct 26, 2020
@sokomishalov @mp911de
ScanStream: replace custom emissions with Mono::expand #1458
6ab359c 
Original pull request: #1468.
mp911de added a commit that referenced this issue Oct 26, 2020
@mp911de
Polishing #1458
803df6c 
Reformat code. Add author tag.

Original pull request: #1468.
@mp911de mp911de added this to the 6.0.1 milestone Oct 26, 2020
@mp911de mp911de closed this as completed Oct 26, 2020
@mp911de mp911de changed the title Investigate Flux/Mono.expand(…) for ScanStream Switch to Flux/Mono.expand(…) for ScanStream Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
6.0.1
Development

No branches or pull requests
1 participant
@mp911de