Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve unsupported error logging for CommandOutput #1532

Closed
mp911de opened this issue Nov 27, 2020 · 0 comments
Closed

Improve unsupported error logging for CommandOutput #1532

mp911de opened this issue Nov 27, 2020 · 0 comments
Labels
type: feature A new feature
Milestone
6.0.2

Comments

@mp911de
Copy link
Collaborator

mp911de commented Nov 27, 2020

Right now, not-implemented template methods of CommandOutput throw a raw IllegalStateException without further details. This can make debugging hard since the actual output type isn't shown in that context. It would be nicer to have messages such as: io.lettuce.core.output.StatusOutput does not support set(long).

Also, we should change IllegalStateException to UnsupportedOperationException to reflect the nature of the failure.

Ideally, we introduce better error messages with 6.0.2 and apply the exception type change with 6.1.
@mp911de mp911de added this to the 6.0.2 milestone Nov 27, 2020
@mp911de mp911de added the type: feature A new feature label Nov 27, 2020
mp911de added a commit that referenced this issue Nov 27, 2020
@mp911de
Improve unsupported error logging for CommandOutput #1532
e735490 
Exceptions now report the actual output name.
mp911de added a commit that referenced this issue Nov 27, 2020
@mp911de
Improve unsupported error logging for CommandOutput #1532
ab9c760 
Exceptions now report the actual output name.
mp911de added a commit that referenced this issue Nov 27, 2020
@mp911de
Throw UnsupportedOperationException when calling not supported Comman…
7df7eee 
…dOutput methods #1532

Lettuce now throws UnsupportedOperationException instead of IllegalStateException to reflect the actual nature of the failure.
@mp911de mp911de closed this as completed Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.0.2
Development

No branches or pull requests
1 participant
@mp911de