Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ACL commands #1538

Closed
GraemeMitchell84 opened this issue Nov 30, 2020 · 1 comment
Closed

Support for ACL commands #1538

GraemeMitchell84 opened this issue Nov 30, 2020 · 1 comment
Assignees
Labels
status: help-wanted An issue that a contributor can help us with type: feature A new feature
Milestone

Comments

@GraemeMitchell84
Copy link

It would be great if lettuce could be able to support the [ACL * commands] (https://redis.io/commands), such as ACL GETUSER, ACL SETUSER, etc. I have looked through the docs and don't see any evidence of support just yet, and I know this is relatively new in Redis.

The reason for this is that redis currently has a limitation (in my eyes) when managing users in a cluster. The ACL is managed independently on each node in the server, rather than being propagated to each node automatically. See this question that I raised on the redis github.

This raises a challenge for administrators to manually keep their cluster in sync with regards to access management. I want this to be a simple administrative activity for our teams, and would like to manage this through a UI / API services. I don't want the potential for human error in these important processes. While I don't want to have to manually keep the cluster in sync, providing access to the core ACL commands in Lettuce would allow me to programmatically keep our clusters in sync, or choose how I want to manage users in our clusters.

Should Redis choose to implement this feature in future to sync ACL across a cluster, it would still be good to have ACL commands in lettuce to allow for administrative management programmatically, so that modern applications may be written to manage it.

@GraemeMitchell84 GraemeMitchell84 added the type: feature A new feature label Nov 30, 2020
@mp911de mp911de added the status: help-wanted An issue that a contributor can help us with label Nov 30, 2020
@mp911de
Copy link
Collaborator

mp911de commented Nov 30, 2020

Thanks a lot. Given that usecase, it makes sense to provide a programmatic API. ACL should be stable by now so we can provide proper API support here.

@mp911de mp911de added this to the 6.1 M1 milestone Dec 15, 2020
@mp911de mp911de modified the milestones: 6.1 M1, 6.1 M2 Jan 8, 2021
@sokomishalov sokomishalov self-assigned this Jan 15, 2021
sokomishalov added a commit to sokomishalov/lettuce that referenced this issue Feb 9, 2021
@mp911de mp911de linked a pull request Mar 2, 2021 that will close this issue
@mp911de mp911de closed this as completed Mar 2, 2021
mp911de pushed a commit that referenced this issue Mar 2, 2021
Original pull request: #1602.
mp911de added a commit that referenced this issue Mar 2, 2021
Tweak Javadoc. Remove UserRulesOutput in favor of introducing a model parser later on.
Switch Enum output to construct an enum set.
Reformat code. Update since tags.

Original pull request: #1602.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help-wanted An issue that a contributor can help us with type: feature A new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants