Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename zrandmemberWithscores to zrandmemberWithScores #1663

Closed
dengliming opened this issue Mar 16, 2021 · 3 comments · Fixed by #1666
Closed

Rename zrandmemberWithscores to zrandmemberWithScores #1663

dengliming opened this issue Mar 16, 2021 · 3 comments · Fixed by #1666
Labels
type: task A general task
Milestone
6.1 RC1

Comments

@dengliming
Copy link
Contributor

No description provided.

@dengliming dengliming added the type: regression A regression from a previous release label Mar 16, 2021
@dengliming
Copy link
Contributor Author

@mp911de We don't have a release for this command yet. Can we keep consistent with other places?

@mp911de
Copy link
Collaborator

mp911de commented Mar 16, 2021

Sure. Do you want to submit a PR? Commands introduced in the 6.1 line can be changed right away. We should only watch out for commands that were introduced in earlier versions to not break their signature. I plan to ship 6.1 RC1 today so we can use it in Spring Data Redis.

@dengliming
Copy link
Contributor Author

Got it. I will submit a PR to do this later.

@dengliming dengliming mentioned this issue Mar 16, 2021
Merged
4 tasks
@mp911de mp911de added type: task A general task and removed type: regression A regression from a previous release labels Mar 16, 2021
@mp911de mp911de added this to the 6.1 RC1 milestone Mar 16, 2021
mp911de pushed a commit that referenced this issue Mar 16, 2021
@dengliming
Rename zrandmemberWithscores to zrandmemberWithScores #1663
88e612d 
Original pull request: #1666.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
6.1 RC1
Development

Successfully merging a pull request may close this issue.

Rename zrandmemberWithscores to zrandmemberWithScores dengliming/lettuce-core
2 participants
@mp911de @dengliming