Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing ClusterNodeEndpoint asynchronously doesn't retrigger buffered commands #1769

Closed
mp911de opened this issue Jun 9, 2021 · 0 comments
Closed

Closing ClusterNodeEndpoint asynchronously doesn't retrigger buffered commands #1769

mp911de opened this issue Jun 9, 2021 · 0 comments
Labels
type: bug A general bug
Milestone
6.0.6

Comments

@mp911de
Copy link
Collaborator

mp911de commented Jun 9, 2021

As per #1757, when ClusterNodeEndpoint contains buffered commands and it gets closed asynchronously (i.e. during topology refresh), then it doesn't retrigger buffered commands. This is, because ClusterNodeEndpoint overrides the blocking close method only and not closeAsync.
@mp911de mp911de added the type: bug A general bug label Jun 9, 2021
@mp911de mp911de added this to the 6.0.6 milestone Jun 9, 2021
mp911de added a commit that referenced this issue Jun 9, 2021
@mp911de
Fix command retrigger when closing ClusterNodeEndpoint asynchronously #…
a96e243 
…1769

ClusterNodeEndpoint now overrides the correct close method.
mp911de added a commit that referenced this issue Jun 9, 2021
@mp911de
Fix command retrigger when closing ClusterNodeEndpoint asynchronously #…
5a0ddd9 
…1769

ClusterNodeEndpoint now overrides the correct close method.
mp911de added a commit that referenced this issue Jun 9, 2021
@mp911de
Fix command retrigger when closing ClusterNodeEndpoint asynchronously #…
1928fe5 
…1769

ClusterNodeEndpoint now overrides the correct close method.
@mp911de mp911de closed this as completed Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug A general bug
Projects
None yet
Milestone
6.0.6
Development

No branches or pull requests
1 participant
@mp911de