Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ZMSCORE、SMISMEMBER command #1456

Closed
wants to merge 2 commits into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Oct 10, 2020

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

closes #1449 and #1452

@codecov
Copy link

codecov bot commented Oct 10, 2020

Codecov Report

Merging #1456 into main will decrease coverage by 0.14%.
The diff coverage is 89.65%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1456      +/-   ##
============================================
- Coverage     78.92%   78.78%   -0.15%     
- Complexity     6187     6190       +3     
============================================
  Files           460      461       +1     
  Lines         20800    20827      +27     
  Branches       2302     2302              
============================================
- Hits          16417    16408       -9     
- Misses         3324     3351      +27     
- Partials       1059     1068       +9     
Impacted Files Coverage Δ Complexity Δ
...e/api/coroutines/RedisSetCoroutinesCommandsImpl.kt 4.54% <0.00%> (-0.22%) 1.00 <0.00> (ø)
.../java/io/lettuce/core/output/DoubleListOutput.java 86.66% <86.66%> (ø) 5.00 <5.00> (?)
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.55% <100.00%> (+0.01%) 424.00 <2.00> (+2.00)
...io/lettuce/core/AbstractRedisReactiveCommands.java 89.27% <100.00%> (+0.04%) 414.00 <2.00> (+2.00)
...main/java/io/lettuce/core/RedisCommandBuilder.java 94.74% <100.00%> (+0.02%) 463.00 <2.00> (+2.00)
...ain/java/io/lettuce/core/protocol/CommandType.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...io/lettuce/core/protocol/ChannelLogDescriptor.java 57.14% <0.00%> (-21.43%) 4.00% <0.00%> (-1.00%)
.../lettuce/core/masterreplica/SentinelConnector.java 65.85% <0.00%> (-17.08%) 6.00% <0.00%> (-2.00%)
...in/java/io/lettuce/core/masterreplica/Timeout.java 62.50% <0.00%> (-12.50%) 3.00% <0.00%> (-1.00%)
.../io/lettuce/core/protocol/ReconnectionHandler.java 75.67% <0.00%> (-8.11%) 21.00% <0.00%> (-1.00%)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d5054...01b9193. Read the comment docs.

@dengliming dengliming changed the title Add support for ZMSCORE key member [member ...] command Add support for ZMSCORE、SMISMEMBER command Oct 11, 2020
@mp911de
Copy link
Collaborator

mp911de commented Oct 12, 2020

Thanks a lot, that went quick 👍
I will have a look in the next days.

@mp911de mp911de modified the milestones: 6.0.1, 6.1 M1 Oct 26, 2020
@mp911de mp911de added the type: feature A new feature label Oct 26, 2020
mp911de pushed a commit that referenced this pull request Oct 26, 2020
mp911de pushed a commit that referenced this pull request Oct 26, 2020
mp911de added a commit that referenced this pull request Oct 26, 2020
Add since tags. Order methods alphabetically. Add zmscore to Coroutines API

Remove StreamingOutput from DoubleListOutput to preserve null elements in List<Double> as ZMSCORE returns (nil) for elements that weren't found and ReactivePublisher emits every list item individually. Since null values are not allowed in Reactive Streams, we need to collect all scores first and then emit the List.

Pin return type of ZMSCORE to List<Double> for the Reactive API.

Guard tests so they don't fail on older Redis versions. Adapt tests.

Original pull request: #1456.
@mp911de
Copy link
Collaborator

mp911de commented Oct 26, 2020

Thank you for your contribution. That's merged and polished now. You might want to have a look at the polishing commit 3a3fd7e to review what changes I applied during the merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZMSCORE key member [member ...] command
2 participants