-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ZMSCORE、SMISMEMBER command #1456
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1456 +/- ##
============================================
- Coverage 78.92% 78.78% -0.15%
- Complexity 6187 6190 +3
============================================
Files 460 461 +1
Lines 20800 20827 +27
Branches 2302 2302
============================================
- Hits 16417 16408 -9
- Misses 3324 3351 +27
- Partials 1059 1068 +9 Continue to review full report at Codecov.
|
Thanks a lot, that went quick 👍 |
Original pull request: #1456.
Original pull request: #1456.
Add since tags. Order methods alphabetically. Add zmscore to Coroutines API Remove StreamingOutput from DoubleListOutput to preserve null elements in List<Double> as ZMSCORE returns (nil) for elements that weren't found and ReactivePublisher emits every list item individually. Since null values are not allowed in Reactive Streams, we need to collect all scores first and then emit the List. Pin return type of ZMSCORE to List<Double> for the Reactive API. Guard tests so they don't fail on older Redis versions. Adapt tests. Original pull request: #1456.
Thank you for your contribution. That's merged and polished now. You might want to have a look at the polishing commit 3a3fd7e to review what changes I applied during the merge. |
Make sure that:
closes #1449 and #1452