Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build break when missing netty-dns-resolver #1547

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

yueki1993
Copy link
Contributor

Fixes: #1546

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
    https://github.com/yueki1993/lettuce-test-PR1517

@@ -51,10 +50,14 @@
return ADDRESS_RESOLVER_GROUP;
}

private static AddressResolverGroup<?> defaultDnsAddressResolverGroup() {
Copy link
Contributor Author

@yueki1993 yueki1993 Dec 3, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here causes NoClassDefError because there are upcasts DnsAddressResolverGroup -> AddressResolverGroup) and DefaultDnsCnameCache -> DnsCnameCache.
I moved these to internal static class.

@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1547 (8951a23) into main (34476f5) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1547      +/-   ##
============================================
- Coverage     78.68%   78.65%   -0.03%     
+ Complexity     6340     6336       -4     
============================================
  Files           476      476              
  Lines         21318    21319       +1     
  Branches       2333     2333              
============================================
- Hits          16774    16769       -5     
- Misses         3472     3475       +3     
- Partials       1072     1075       +3     
Impacted Files Coverage Δ Complexity Δ
...ce/core/resource/AddressResolverGroupProvider.java 73.33% <100.00%> (+1.90%) 2.00 <0.00> (-1.00) ⬆️
.../java/io/lettuce/core/protocol/CommandHandler.java 73.60% <0.00%> (-2.04%) 110.00% <0.00%> (-4.00%)
...a/io/lettuce/core/protocol/ConnectionWatchdog.java 77.77% <0.00%> (-1.97%) 38.00% <0.00%> (-1.00%)
...ce/core/masterreplica/SentinelTopologyRefresh.java 84.96% <0.00%> (-0.66%) 35.00% <0.00%> (ø%)
...java/io/lettuce/core/protocol/DefaultEndpoint.java 70.06% <0.00%> (+0.46%) 99.00% <0.00%> (ø%)
.../io/lettuce/core/dynamic/ReactiveTypeAdapters.java 88.26% <0.00%> (+0.86%) 1.00% <0.00%> (ø%)
.../io/lettuce/core/protocol/CommandExpiryWriter.java 76.92% <0.00%> (+3.84%) 17.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34476f5...8951a23. Read the comment docs.

@mp911de mp911de merged commit a7a1bda into redis:main Dec 22, 2020
@mp911de mp911de added the type: bug A general bug label Dec 22, 2020
@mp911de mp911de added this to the 6.1 M1 milestone Dec 22, 2020
@yueki1993 yueki1993 deleted the fix-build-break branch December 22, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build break when missing netty-dns-resolver
3 participants