Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for parameter TYPE of command SCAN #1560

Closed
wants to merge 1 commit into from
Closed

Added support for parameter TYPE of command SCAN #1560

wants to merge 1 commit into from

Conversation

mvmn
Copy link
Contributor

@mvmn mvmn commented Dec 13, 2020 •
edited
Loading

DRAFT! DOES NOT INCLUDE TESTS FOR NEW PARAMETER!

Please update to make it correspond to project standards.

@mvmn mvmn mentioned this pull request Dec 13, 2020
Closed
@mvmn mvmn changed the title Issue 1461: Added support for parameter TYPE of command SCAN Issue 1559: Added support for parameter TYPE of command SCAN Dec 13, 2020
@codecov
Copy link

codecov bot commented Dec 13, 2020 •
edited
Loading

Codecov Report

Merging #1560 (d8942f5) into main (34476f5) will decrease coverage by 0.05%.
The diff coverage is 68.18%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1560      +/-   ##
============================================
- Coverage     78.68%   78.62%   -0.06%     
+ Complexity     6340     6338       -2     
============================================
  Files           476      477       +1     
  Lines         21318    21334      +16     
  Branches       2333     2334       +1     
============================================
  Hits          16774    16774              
- Misses         3472     3482      +10     
- Partials       1072     1078       +6
Impacted Files Coverage Δ Complexity Δ
...va/io/lettuce/core/AbstractRedisAsyncCommands.java 96.00% <ø> (ø) 432.00 <0.00> (ø)
...io/lettuce/core/AbstractRedisReactiveCommands.java 88.91% <ø> (ø) 422.00 <0.00> (ø)
src/main/java/io/lettuce/core/ScanIterator.java 95.31% <ø> (ø) 13.00 <0.00> (ø)
src/main/java/io/lettuce/core/ScanStream.java 100.00% <ø> (ø) 27.00 <0.00> (ø)
...cluster/RedisAdvancedClusterAsyncCommandsImpl.java 83.18% <ø> (-1.73%) 89.00 <0.00> (-2.00)
...ster/RedisAdvancedClusterReactiveCommandsImpl.java 73.71% <ø> (ø) 74.00 <0.00> (ø)
...r/api/async/RedisAdvancedClusterAsyncCommands.java 44.44% <ø> (ø) 6.00 <0.00> (ø)
...e/api/coroutines/RedisKeyCoroutinesCommandsImpl.kt 2.85% <0.00%> (ø) 1.00 <0.00> (ø)
src/main/java/io/lettuce/core/KeyScanArgs.java 68.75% <68.75%> (ø) 5.00 <5.00> (?)
src/main/java/io/lettuce/core/KillArgs.java 75.00% <100.00%> (ø) 11.00 <0.00> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34476f5...d8942f5. Read the comment docs.

@mp911de mp911de added this to the 6.1 M1 milestone Dec 15, 2020
@mp911de
Copy link
Collaborator

mp911de commented Dec 22, 2020

I'm going to take this PR from here. Introducing KeyScanArgs makes a lot of sense, however, we should not change method argument types as that breaks existing code. Instead, we should mention in the docs to use KeyScanArgs for extended SCAN args support.

mp911de pushed a commit that referenced this pull request Dec 22, 2020
@mvmn @mp911de
Added support for parameter TYPE of command SCAN #1559
5b84092 
Original pull request: #1560.
mp911de added a commit that referenced this pull request Dec 22, 2020
@mp911de
Polishing #1559
67a93f6 
Revert method signature changes. Change tabs to spaces, add Javadoc and license header.

Update SCAN javadoc to reference KeyScanArgs. Add integration test.

Original pull request: #1560.
@mp911de
Copy link
Collaborator

mp911de commented Dec 22, 2020

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Dec 22, 2020
@mp911de mp911de added the type: feature A new feature label Dec 22, 2020
@mp911de mp911de changed the title Issue 1559: Added support for parameter TYPE of command SCAN Added support for parameter TYPE of command SCAN Dec 22, 2020
@BalmungSan BalmungSan mentioned this pull request Aug 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 M1
Development

Successfully merging this pull request may close these issues.
2 participants
@mvmn @mp911de