Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SYNC arg to FLUSHALL and FLUSHDB, and ASYNC/SYNC arg to SCRIPT FLUSH #1646

Closed
wants to merge 2 commits into from
Closed

Add SYNC arg to FLUSHALL and FLUSHDB, and ASYNC/SYNC arg to SCRIPT FLUSH #1646

wants to merge 2 commits into from

Conversation

dengliming
Copy link
Contributor

@dengliming dengliming commented Mar 6, 2021 •
edited
Loading

Resolves #1608

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

mp911de pushed a commit that referenced this pull request Mar 9, 2021
@dengliming @mp911de
Add FlushMode to FLUSHALL and FLUSHDB, and to SCRIPT FLUSH #1608
4f590cc 
Original pull request: #1646.
mp911de added a commit that referenced this pull request Mar 9, 2021
@mp911de
Polishing #1608
243d1cc 
Fix API template by importing FlushMode. Deprecate flushallAsync and flushdbAsync in favor of their variants accepting FlushMode. Let FlushMode implement ProtocolKeyword. Tweak Javadoc.

Original pull request: #1646.
@mp911de
Copy link
Collaborator

mp911de commented Mar 9, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 9, 2021
@mp911de mp911de added this to the 6.1 RC1 milestone Mar 9, 2021
@mp911de mp911de added the type: feature A new feature label Mar 9, 2021
@dengliming dengliming deleted the sync-sync-flush branch March 9, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.1 RC1
Development

Successfully merging this pull request may close these issues.

Add FlushMode to FLUSHALL and FLUSHDB, and to SCRIPT FLUSH
2 participants
@dengliming @mp911de