Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Bootstrap with reconfigured SslChannelInitializer upon reconnect #1836

Closed
wants to merge 1 commit into from

Conversation

aashishamrute
Copy link
Contributor

@aashishamrute aashishamrute commented Aug 30, 2021

fixes #1812
During reconnect, the SSL channel initializer will get rebuild with a new socket address.
When sentinel announces new master, CN name of the certificate should be checked against new master, currently it is check against old master.

@mp911de mp911de added the type: bug A general bug label Aug 31, 2021
@aashishamrute aashishamrute changed the title SSL chanel reinitialize on reconnect (fixes #1812) SSL chanel reinitialize on reconnect (fixes lettuce-io/lettuce-core#1812) Sep 1, 2021
@aashishamrute aashishamrute changed the title SSL chanel reinitialize on reconnect (fixes lettuce-io/lettuce-core#1812) SSL chanel reinitialize on reconnect (fixes #1812) Sep 1, 2021
@mp911de mp911de changed the title SSL chanel reinitialize on reconnect (fixes #1812) Update Bootstrap with reconfigured SslChannelInitializer upon reconnect Sep 3, 2021
@mp911de mp911de added this to the 6.0.8 milestone Sep 3, 2021
mp911de pushed a commit that referenced this pull request Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Move SslChannelInitializer creation from SslConnectionBuilder into SslChannelInitializer. Tweak method names.

Original pull request: #1836.
mp911de pushed a commit that referenced this pull request Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Move SslChannelInitializer creation from SslConnectionBuilder into SslChannelInitializer. Tweak method names.

Original pull request: #1836.
mp911de pushed a commit that referenced this pull request Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Move SslChannelInitializer creation from SslConnectionBuilder into SslChannelInitializer. Tweak method names.

Original pull request: #1836.
@mp911de
Copy link
Collaborator

mp911de commented Sep 3, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSL CN name checked failed after Redis Sentinel failover
2 participants