Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle calls to DefaultPauseDetectorWrapper#retain during shutdown. #1884

Closed
wants to merge 3 commits into from
Closed

Gracefully handle calls to DefaultPauseDetectorWrapper#retain during shutdown. #1884

wants to merge 3 commits into from

Conversation

craftmaster2190
Copy link
Contributor

@craftmaster2190 craftmaster2190 commented Oct 20, 2021

fixes #1883

  • Gracefully handle calls to DefaultPauseDetectorWrapper#retain during shutdown
  • Use mockito-inline to test static method Runtime#getRuntime()
  • Unit test mocked shutdown behavior

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes. I do not use eclipse. However, I did try to match the surrounding style.
  • You submit test cases (unit or integration tests) that back your changes.

@mp911de mp911de added the type: bug A general bug label Dec 3, 2021
@mp911de mp911de added this to the 6.0.9 milestone Dec 3, 2021
mp911de pushed a commit that referenced this pull request Dec 3, 2021
mp911de pushed a commit that referenced this pull request Dec 3, 2021
mp911de pushed a commit that referenced this pull request Dec 3, 2021
@mp911de
Copy link
Collaborator

mp911de commented Dec 3, 2021

Thank you for your contribution. That's merged and backported now. I cherry-picked only the actual change as this is quite an edge-case because the client should be shut down before the JVM starts its shutdown process.

@mp911de mp911de closed this Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
2 participants