Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added getConnection() methods that take a ConnectionIntent to Cluster… #2096

Closed
wants to merge 1 commit into from
Closed

Added getConnection() methods that take a ConnectionIntent to Cluster… #2096

wants to merge 1 commit into from

Conversation

mikeamzn
Copy link
Contributor

…ConnectionProvider

Refactored Intent to be a top level public enum.
Refactored usages & comments.

#2095

@mikeamzn
Added getConnection() methods that take a ConnectionIntent to Cluster…
2a8d664 
…ConnectionProvider

Refactored Intent to be a top level public enum.
Refactored usages & comments.

redis#2095
@mikeamzn mikeamzn mentioned this pull request May 16, 2022
Closed
@mp911de mp911de added the type: feature A new feature label May 17, 2022
@mp911de mp911de linked an issue May 17, 2022 that may be closed by this pull request
StatefulRedisClusterConnectionImpl getConnection always calls connection provider with Intent.WRITE #2095
Closed
@mikeamzn
Copy link
Contributor Author

Is there a specific cadence on when you merge PRs? Just trying to get an idea on timing of having this feature available.

mp911de pushed a commit that referenced this pull request Jul 7, 2022
@mikeamzn @mp911de
Added getConnection() methods that take a ConnectionIntent to Cluster…
bd69ddc 
…ConnectionProvider #2095

Refactored Intent to be a top level public enum.
Refactored usages & comments.

Original pull request: #2096.
mp911de added a commit that referenced this pull request Jul 7, 2022
@mp911de
Polishing #2095
192d5f5 
Move ConnectionIntent to protocol package. Refactor Master/Replica code to use shared ConnectionIntent type. Add since tags, license headers and update Javadoc.

Original pull request: #2096.
@mp911de mp911de added this to the 6.2.0 milestone Jul 7, 2022
@mp911de
Copy link
Collaborator

mp911de commented Jul 7, 2022

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.2.0.RELEASE
Development

Successfully merging this pull request may close these issues.

StatefulRedisClusterConnectionImpl getConnection always calls connection provider with Intent.WRITE
2 participants
@mikeamzn @mp911de