Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque #2601

Closed
wants to merge 1 commit into from
Closed

Eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque #2601

wants to merge 1 commit into from

Conversation

okg-cxf
Copy link
Contributor

@okg-cxf okg-cxf commented Jan 18, 2024 •
edited
Loading

perf: eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque)

refer to #2602

  • [Y] You have read the contribution guidelines.
  • [Y] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • [Y] You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • [Y] You submit test cases (unit or integration tests) that back your changes.

@okg-cxf okg-cxf changed the title perf: eliminate unnecessary expensive size() calls, use ConcurrentLin… perf: eliminate unnecessary expensive size() calls Jan 18, 2024
@okg-cxf okg-cxf force-pushed the perf/refine-disconnected-buffer-queue branch from 9271c1b to 999bf12 Compare January 18, 2024 08:14
@okg-cxf okg-cxf mentioned this pull request Jan 18, 2024
Closed
@okg-cxf okg-cxf changed the title perf: eliminate unnecessary expensive size() calls perf: eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque Jan 18, 2024
@okg-cxf okg-cxf force-pushed the perf/refine-disconnected-buffer-queue branch from 999bf12 to 6db3c87 Compare January 18, 2024 08:25
@mp911de mp911de changed the title perf: eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque Eliminate unnecessary expensive size() calls, use ConcurrentLinkedQueue instead of ConcurrentLinkedDeque Feb 26, 2024
@mp911de mp911de added the type: feature A new feature label Feb 26, 2024
@mp911de mp911de added this to the 6.3.2.RELEASE milestone Feb 26, 2024
mp911de added a commit that referenced this pull request Feb 26, 2024
@mp911de
Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602
faffc7e 
See also #2601
mp911de added a commit that referenced this pull request Feb 26, 2024
@mp911de
Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602
18750c1 
See also #2601
@mp911de
Copy link
Collaborator

mp911de commented Feb 26, 2024

Thank you for your contribution. That's slightly altered because of the many unrelated changes and merged as 18750c1.

@mp911de mp911de closed this Feb 26, 2024
@mp911de mp911de linked an issue Feb 26, 2024 that may be closed by this pull request
Switch to ConcurrentLinkedQueue to avoid expensive size calls #2602
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: feature A new feature
Projects
None yet
Milestone
6.3.2.RELEASE
Development

Successfully merging this pull request may close these issues.

Switch to ConcurrentLinkedQueue to avoid expensive size calls
2 participants
@okg-cxf @mp911de